netdev - Re: [PATCH net-next v1 1/2] ethtool/uapi: use BIT for bit-shifts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e51d68f9-e7b2-39d7-154e-f508615b50d0@intel.com>
Date:   Fri, 9 Dec 2022 14:17:31 -0800
From:   Jesse Brandeburg <jesse.brandeburg@...el.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     <davem@...emloft.net>, <pabeni@...hat.com>,
        <netdev@...r.kernel.org>, <mkubecek@...e.cz>
Subject: Re: [PATCH net-next v1 1/2] ethtool/uapi: use BIT for bit-shifts

On 12/7/2022 6:41 PM, Jakub Kicinski wrote:
> On Wed,  7 Dec 2022 15:17:27 -0800 Jesse Brandeburg wrote:
>>   #define ETH_RSS_HASH_TOP	__ETH_RSS_HASH(TOP)
>> diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h
>> index 58e587ba0450..6ce5da444098 100644
>> --- a/include/uapi/linux/ethtool.h
>> +++ b/include/uapi/linux/ethtool.h
>> @@ -9,6 +9,7 @@
>>    *                                christopher.leech@...el.com,
>>    *                                scott.feldman@...el.com)
>>    * Portions Copyright (C) Sun Microsystems 2008
>> + * Portions Copyright (C) 2022 Intel Corporation
> 
> Is that appropriate?

I added it when I thought I had to make more changes. Since these 
changes are now minimal I'll remove it, thanks!

>> +#define BIT(nr)		(UL(1) << (nr))
>> +/* include/linux/bits.h */
>> +#define BIT_ULL(nr)	(ULL(1) << (nr))
> 
> include/uapi/linux/const.h

Wow, that was really not obvious that file was there, I searched all up 
and down for BIT() and BIT_ULL versions in the include/* and 
Documentation directory and totally missed that. I'll respin with the 
const.h versions! That file should really mention BIT or BIT_ULL in the 
comments so it would be caught by a grep!