netdev - Re: [PATCH net-next] net: tso: inline tso_count

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 8 Dec 2022 19:59:50 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Yunsheng Lin <linyunsheng@...wei.com>
Cc:     <davem@...emloft.net>, <pabeni@...hat.com>, <edumazet@...gle.com>,
        <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linuxarm@...neuler.org>
Subject: Re: [PATCH net-next] net: tso: inline tso_count_descs()

On Thu, 8 Dec 2022 19:57:21 -0800 Jakub Kicinski wrote:
> On Thu, 8 Dec 2022 10:43:03 +0800 Yunsheng Lin wrote:
> > tso_count_descs() is a small function doing simple calculation,
> > and tso_count_descs() is used in fast path, so inline it to
> > reduce the overhead of calls.  
> 
> TSO frames are large, the overhead is fine.
> I'm open to other opinions but I'd rather keep the code as is than
> deal with the influx with similar sloppily automated changes.

Oh, wait, you're not one of the bot people. Sorry, please just address
my comments and post a v2.

There is a lot of poorly written patches coming from @huawei addresses
which are giving the company a bad name :(