netdev - Re: [PATCH net 0/3] Bonding: fix high prio not effect issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 09 Dec 2022 16:01:07 -0800
From:   Jay Vosburgh <jay.vosburgh@...onical.com>
To:     Hangbin Liu <liuhangbin@...il.com>
cc:     netdev@...r.kernel.org, "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Jonathan Toppins <jtoppins@...hat.com>,
        Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>, liali <liali@...hat.com>
Subject: Re: [PATCH net 0/3] Bonding: fix high prio not effect issue

Hangbin Liu <liuhangbin@...il.com> wrote:

>When a high prio link up, if there has current link, it will not do
>failover as we missed the check in link up event. Fix it in this patchset
>and add a prio option test case.
>
>Hangbin Liu (2):
>  bonding: access curr_active_slave with rtnl_dereference
>  bonding: do failover when high prio link up
>
>Liang Li (1):
>  selftests: bonding: add bonding prio option test

	For the series:

Acked-by: Jay Vosburgh <jay.vosburgh@...onical.com>

	The only comment I have is that since prio is a signed value, it
would be nice if the selftest tested negative prio values.

	-J


> drivers/net/bonding/bond_main.c               |   6 +-
> .../selftests/drivers/net/bonding/Makefile    |   3 +-
> .../drivers/net/bonding/option_prio.sh        | 246 ++++++++++++++++++
> 3 files changed, 252 insertions(+), 3 deletions(-)
> create mode 100755 tools/testing/selftests/drivers/net/bonding/option_prio.sh
>
>-- 
>2.38.1
>

---
	-Jay Vosburgh, jay.vosburgh@...onical.com