netdev - Re: [PATCH ethtool] JSON output support for Netlink implementation of --show-coalesce option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 9 Dec 2022 20:01:50 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Max Georgiev <glipus@...il.com>
Cc:     Michal Kubecek <mkubecek@...e.cz>, netdev@...r.kernel.org
Subject: Re: [PATCH ethtool] JSON output support for Netlink implementation
 of --show-coalesce option

On Fri, 9 Dec 2022 19:16:10 -0700 Max Georgiev wrote:
> JSON output support for Netlink implementation of --show-coalesce option
> 
> Add --json support for Netlink implementation of --show-coalesce option
> No changes for non-JSON output for this feature.

Nice!

> Same output with --json:
> $ sudo ./ethtool --json --show-coalesce enp9s0u2u1u2
> [ {
>         "ifname": "enp9s0u2u1u2",
>         "rx-usecs: ": 15000,
>         "tx-usecs: ": 0

looks like we have double spurious ': ' in the key?

> +       if (silent && !is_json_context())
>                 putchar('\n');

perhaps we can use show_cr() here as well?

> +                       print_uint(PRINT_JSON, label, NULL,
> mnl_attr_get_u32(attr));
> +       } else {

This looks line-wrapped, perhaps try git send-email for v2?
Also subject should say [PATCH ethtool-next], since it's for
the "next" release.