lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 10 Dec 2022 01:06:16 +0100 From: Jiri Olsa <olsajiri@...il.com> To: Jakub Kicinski <kuba@...nel.org>, "Paul E. McKenney" <paulmck@...nel.org> Cc: Daniel Borkmann <daniel@...earbox.net>, Jiri Olsa <olsajiri@...il.com>, Yonghong Song <yhs@...a.com>, Alexei Starovoitov <alexei.starovoitov@...il.com>, Song Liu <song@...nel.org>, Hao Sun <sunhao.th@...il.com>, Peter Zijlstra <peterz@...radead.org>, bpf <bpf@...r.kernel.org>, Alexei Starovoitov <ast@...nel.org>, John Fastabend <john.fastabend@...il.com>, Andrii Nakryiko <andrii@...nel.org>, Martin KaFai Lau <martin.lau@...ux.dev>, Yonghong Song <yhs@...com>, KP Singh <kpsingh@...nel.org>, Stanislav Fomichev <sdf@...gle.com>, Hao Luo <haoluo@...gle.com>, David Miller <davem@...emloft.net>, Jesper Dangaard Brouer <hawk@...nel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, netdev <netdev@...r.kernel.org>, Thorsten Leemhuis <regressions@...mhuis.info> Subject: Re: BUG: unable to handle kernel paging request in bpf_dispatcher_xdp On Fri, Dec 09, 2022 at 03:34:45PM -0800, Jakub Kicinski wrote: > On Sat, 10 Dec 2022 00:32:07 +0100 Daniel Borkmann wrote: > > fwiw, these should not be necessary, Documentation/RCU/checklist.rst : > > > > [...] One example of non-obvious pairing is the XDP feature in networking, > > which calls BPF programs from network-driver NAPI (softirq) context. BPF > > relies heavily on RCU protection for its data structures, but because the > > BPF program invocation happens entirely within a single local_bh_disable() > > section in a NAPI poll cycle, this usage is safe. The reason that this usage > > is safe is that readers can use anything that disables BH when updaters use > > call_rcu() or synchronize_rcu(). [...] > > FWIW I sent a link to the thread to Paul and he confirmed > the RCU will wait for just the BH. so IIUC we can omit the rcu_read_lock/unlock on bpf_prog_run_xdp side Paul, any thoughts on what we can use in here to synchronize bpf_dispatcher_change_prog with bpf_prog_run_xdp callers? with synchronize_rcu_tasks I'm getting splats like: https://lore.kernel.org/bpf/20221209153445.22182ca5@kernel.org/T/#m0a869f93404a2744884d922bc96d497ffe8f579f synchronize_rcu_tasks_rude seems to work (patch below), but it also sounds special ;-) thanks, jirka --- diff --git a/kernel/bpf/dispatcher.c b/kernel/bpf/dispatcher.c index c19719f48ce0..e6126f07e85b 100644 --- a/kernel/bpf/dispatcher.c +++ b/kernel/bpf/dispatcher.c @@ -124,6 +124,7 @@ static void bpf_dispatcher_update(struct bpf_dispatcher *d, int prev_num_progs) } __BPF_DISPATCHER_UPDATE(d, new ?: (void *)&bpf_dispatcher_nop_func); + synchronize_rcu_tasks_rude(); if (new) d->image_off = noff;
Powered by blists - more mailing lists