netdev - Re: [PATCH net-next 2/2] net: ipa: add IPA v4.7 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48bef9dd-b71c-b6aa-e853-1cf821e88b50@linaro.org>
Date:   Sat, 10 Dec 2022 10:31:14 +0100
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Alex Elder <elder@...aro.org>, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com
Cc:     andersson@...nel.org, agross@...nel.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, elder@...nel.org,
        linux-arm-msm@...r.kernel.org, netdev@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Luca Weiss <luca.weiss@...rphone.com>
Subject: Re: [PATCH net-next 2/2] net: ipa: add IPA v4.7 support



On 9.12.2022 21:22, Alex Elder wrote:
> On 12/8/22 3:22 PM, Konrad Dybcio wrote:
>>
>>
>> On 8.12.2022 22:15, Alex Elder wrote:
>>> Add the necessary register and data definitions needed for IPA v4.7,
>>> which is found on the SM6350 SoC.
>>>
>>> Co-developed-by: Luca Weiss <luca.weiss@...rphone.com>
>>> Signed-off-by: Luca Weiss <luca.weiss@...rphone.com>
>>> Signed-off-by: Alex Elder <elder@...aro.org>
>>> ---
>> [...]
>>> +
>>> +/* Memory configuration data for an SoC having IPA v4.7 */
>>> +static const struct ipa_mem_data ipa_mem_data = {
>>> +    .local_count    = ARRAY_SIZE(ipa_mem_local_data),
>>> +    .local        = ipa_mem_local_data,
>>> +    .imem_addr    = 0x146a9000,
>>> +    .imem_size    = 0x00002000,
>> Should probably be
>>
>> 0x146a8000
>> 0x00003000
>>
>> with an appropriate change in dt to reserve that region.
>>
>> Qualcomm does:
>> ipa@... { qcom,additional-mapping = <0x146a8000 0x146a8000 0x2000>; };
>>
>> which covers 0x146a8000-0x146a9fff
>>
>> plus
>>
>> imem@.. { reg = <0x146aa000 0x1000>; };
>>
>> which in total gives us 0x146a8000-0x146aafff
> 
> Can you tell me where you found this information?
[1], [2]

> 
>> That would also mean all of your writes are kind of skewed, unless
>> you already applied some offsets to them.
> 
> This region is used by the modem, but must be set up
> by the AP.
> 
>> (IMEM on 6350 starts at 0x14680000 and is 0x2e000 long, as per
>> the bootloader memory map)
> 
> On SM7250 (sorry, I don't know about 7225, or 6350 for that matter),
> the IMEM starts at 0x14680000 and has length 0x2c000.  However that
> memory is used by multiple entities.  The portion set aside for IPA
> starts at 0x146a9000 and has size 0x2000.
> 
Not sure how 7250 relates to 6350, but I don't think there's much
overlap..


Konrad

[1] https://github.com/sonyxperiadev/kernel/blob/aosp/LA.UM.9.12.r1/arch/arm64/boot/dts/qcom/lagoon.dtsi#L3698-L3707

[2] https://github.com/sonyxperiadev/kernel/blob/aosp/LA.UM.9.12.r1/arch/arm64/boot/dts/qcom/lagoon.dtsi#L1004-L1045
>                     -Alex
> 
>> Konrad
>