netdev - Redundant changes in "net: dsa: mt7530: add support for in-band link status"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y5b/Tm4GwPGzd9sR@shell.armlinux.org.uk>
Date:   Mon, 12 Dec 2022 10:15:42 +0000
From:   "Russell King (Oracle)" <linux@...linux.org.uk>
To:     Daniel Golle <daniel@...rotopia.org>, netdev@...r.kernel.org
Subject: Redundant changes in "net: dsa: mt7530: add support for in-band link
 status"

Hi Daniel,

While updating my tree, I notice that the above referenced commit
contains a redundant change, namely in mt753x_phylink_get_caps():

        config->mac_capabilities = MAC_ASYM_PAUSE | MAC_SYM_PAUSE |
                                   MAC_10 | MAC_100 | MAC_1000FD;

+       if ((priv->id == ID_MT7531) && mt753x_is_mac_port(port))
+               config->mac_capabilities |= MAC_2500FD;
+

This shouldn't be necessary. mt753x_phylink_get_caps() goes on to
call the obviously named mt753x "mac_port_get_caps" method, which
for a MT7531 is mt7531_mac_port_get_caps().

mt7531_mac_port_get_caps() will already set MAC_2500FD for ports
5 and 6 where appropriate.

Please submit a patch to remove the above change if you agree that
it is already covered.

Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!