netdev - Re: [PATCH net] nfc: pn533: Clear nfc_target in pn533_poll_dep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6149eb8e-74dc-46bd-029f-309c4224a005@linaro.org>
Date:   Tue, 13 Dec 2022 15:40:22 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Minsuk Kang <linuxlovemin@...sei.ac.kr>, netdev@...r.kernel.org
Cc:     linma@....edu.cn, davem@...emloft.net, sameo@...ux.intel.com,
        dokyungs@...sei.ac.kr, jisoo.jang@...sei.ac.kr
Subject: Re: [PATCH net] nfc: pn533: Clear nfc_target in
 pn533_poll_dep_complete() before being used

On 13/12/2022 15:20, Minsuk Kang wrote:

> 
>>> ==================================================================
>>>
>>> Fixes: 673088fb42d0 ("NFC: pn533: Send ATR_REQ directly for active device detection")
>>> Reported-by: Dokyung Song <dokyungs@...sei.ac.kr>
>>> Reported-by: Jisoo Jang <jisoo.jang@...sei.ac.kr>
>>> Reported-by: Minsuk Kang <linuxlovemin@...sei.ac.kr>
>>
>> Reported-by is for crediting other people, not crediting yourself.
>> Otherwise all my patches would be reported-by, right? Please drop this
>> one and keep only credit for other people who actually reported it. It's
>> anyway weird to see three people reporting one bug.
>>
>> Additionally I really dislike private reports because they sometimes
>> cannot be trusted (see all the fake report credits from running
>> coccinelle by Hulk Robot and others)... Care to provide link to the
>> reports of this bug?
>>
> 
> My intention was to credit all the people contributed to the
> modification of syzkaller that led to this bug. But I will drop them in
> v2.

Then shouldn't you also credit all authors of original syzkaller as
well? And people who wrote core libraries being used there? Let's don't
go that way...

Best regards,
Krzysztof