netdev - Re: [PATCH] net: Fix for packets being rejected in the xHCI controller's ring buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y5jHJJS31+6Smk5L@kroah.com>
Date:   Tue, 13 Dec 2022 19:40:36 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     "Seija K." <doremylover123@...il.com>
Cc:     Bjørn Mork <bjorn@...k.no>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: Fix for packets being rejected in the xHCI
 controller's ring buffer

On Tue, Dec 13, 2022 at 12:14:28PM -0500, Seija K. wrote:
> When a packet larger than MTU arrives in Linux from the modem,
> it is discarded with -EOVERFLOW error (Babble error).
> 
> This is seen on USB3.0 and USB2.0 buses.
> 
> This is because the MRU (Max Receive Size) is not a separate entity
> from the MTU (Max Transmit Size),
> and the received packets can be larger than those transmitted.
> 
> Following the babble error, there was an endless supply of zero-length URBs,
> which are rejected with -EPROTO (increasing the rx input error counter
> each time).
> 
> This is only seen on USB3.0.
> These continue to come ad infinitum until the modem is shut down.
> 
> There appears to be a bug in the core USB handling code in Linux
> that doesn't deal well with network MTUs smaller than 1500 bytes.
> 
> By default, the dev->hard_mtu (the real MTU)
> is in lockstep with dev->rx_urb_size (essentially an MRU),
> and the latter is causing trouble.
> 
> This has nothing to do with the modems,
> as the issue can be reproduced by getting a USB-Ethernet dongle,
> setting the MTU to 1430, and pinging with size greater than 1406.
> 
> Signed-off-by: Seija Kijin <doremylover123@...il.com>
> Co-Authored-By: TarAldarion <gildeap@....ie>
> 
> diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
> index 554d4e2a84a4..39db53a74b5a 100644
> --- a/drivers/net/usb/qmi_wwan.c
> +++ b/drivers/net/usb/qmi_wwan.c
> @@ -842,6 +842,13 @@ static int qmi_wwan_bind(struct usbnet *dev,
> struct usb_interface *intf)
> }
> dev->net->netdev_ops = &qmi_wwan_netdev_ops;
> dev->net->sysfs_groups[0] = &qmi_wwan_sysfs_attr_group;
> + /* LTE Networks don't always respect their own MTU on receive side;
> + * e.g. AT&T pushes 1430 MTU but still allows 1500 byte packets from
> + * far-end network. Make the receive buffer large enough to accommodate
> + * them, and add four bytes so MTU does not equal MRU on network
> + * with 1500 MTU otherwise usbnet_change_mtu() will change both.
> + */
> + dev->rx_urb_size = ETH_DATA_LEN + 4;
> err:
> return status;
> }

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch is malformed (tabs converted to spaces, linewrapped, etc.)
  and can not be applied.  Please read the file,
  Documentation/process/email-clients.rst in order to fix this.

- It looks like you did not use your "real" name for the patch on either
  the Signed-off-by: line, or the From: line (both of which have to
  match).  Please read the kernel file,
  Documentation/process/submitting-patches.rst for how to do this
  correctly.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot