lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 13 Dec 2022 14:38:41 -0800 From: Alexander H Duyck <alexander.duyck@...il.com> To: "Hans J. Schultz" <netdev@...io-technology.com>, davem@...emloft.net, kuba@...nel.org Cc: netdev@...r.kernel.org, Andrew Lunn <andrew@...n.ch>, Florian Fainelli <f.fainelli@...il.com>, Vladimir Oltean <olteanv@...il.com>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, open list <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v2 net-next 1/3] net: dsa: mv88e6xxx: change default return of mv88e6xxx_port_bridge_flags On Tue, 2022-12-13 at 18:46 +0100, Hans J. Schultz wrote: > The default return value -EOPNOTSUPP of mv88e6xxx_port_bridge_flags() > came from the return value of the DSA method port_egress_floods() in > commit 4f85901f0063 ("net: dsa: mv88e6xxx: add support for bridge flags"), > but the DSA API was changed in commit a8b659e7ff75 ("net: dsa: act as > passthrough for bridge port flags"), resulting in the return value > -EOPNOTSUPP not being valid anymore, and sections for new flags will not > need to set the return value to zero on success, as with the new mab flag > added in a following patch. > > Signed-off-by: Hans J. Schultz <netdev@...io-technology.com> > --- > drivers/net/dsa/mv88e6xxx/chip.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c > index ba4fff8690aa..d5930b287db4 100644 > --- a/drivers/net/dsa/mv88e6xxx/chip.c > +++ b/drivers/net/dsa/mv88e6xxx/chip.c > @@ -6546,7 +6546,7 @@ static int mv88e6xxx_port_bridge_flags(struct dsa_switch *ds, int port, > struct netlink_ext_ack *extack) > { > struct mv88e6xxx_chip *chip = ds->priv; > - int err = -EOPNOTSUPP; > + int err = 0; > > mv88e6xxx_reg_lock(chip); > Reviewed-by: Alexander Duyck <alexanderduyck@...com>
Powered by blists - more mailing lists