lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 13 Dec 2022 11:44:37 +0100 From: Stefano Garzarella <sgarzare@...hat.com> To: Arseniy Krasnov <AVKrasnov@...rdevices.ru> Cc: "edumazet@...gle.com" <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, "David S. Miller" <davem@...emloft.net>, Paolo Abeni <pabeni@...hat.com>, Bobby Eshleman <bobby.eshleman@...edance.com>, Krasnov Arseniy <oxffffaa@...il.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "virtualization@...ts.linux-foundation.org" <virtualization@...ts.linux-foundation.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, kernel <kernel@...rdevices.ru> Subject: Re: [RFC PATCH v4 1/4] vsock: return errors other than -ENOMEM to socket On Tue, Dec 06, 2022 at 08:49:19PM +0000, Arseniy Krasnov wrote: >From: Bobby Eshleman <bobby.eshleman@...edance.com> > >This removes behaviour, where error code returned from any transport >was always switched to ENOMEM. For example when user tries to send too >big message via SEQPACKET socket, transport layers return EMSGSIZE, but >this error code will be replaced to ENOMEM and returned to user. Just a minor thing here, I would write "this error code was always replaced with ENOMEM and returned to user" To make it clearer that it was the previous behavior. Anyway, the patch LGTM: Reviewed-by: Stefano Garzarella <sgarzare@...hat.com> > >Signed-off-by: Bobby Eshleman <bobby.eshleman@...edance.com> >Signed-off-by: Arseniy Krasnov <AVKrasnov@...rdevices.ru> >--- > net/vmw_vsock/af_vsock.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c >index 884eca7f6743..61ddab664c33 100644 >--- a/net/vmw_vsock/af_vsock.c >+++ b/net/vmw_vsock/af_vsock.c >@@ -1862,8 +1862,9 @@ static int vsock_connectible_sendmsg(struct socket *sock, struct msghdr *msg, > written = transport->stream_enqueue(vsk, > msg, len - total_written); > } >+ > if (written < 0) { >- err = -ENOMEM; >+ err = written; > goto out_err; > } > >-- >2.25.1
Powered by blists - more mailing lists