netdev - Re: [PATCH net v2 0/5] net: wangxun: Adjust code structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5b837adf6f912cbd152d42b1ef0271c58d6e3690.camel@gmail.com>
Date:   Wed, 14 Dec 2022 08:44:01 -0800
From:   Alexander H Duyck <alexander.duyck@...il.com>
To:     Jiawen Wu <jiawenwu@...stnetic.com>, netdev@...r.kernel.org,
        mengyuanlou@...-swift.com
Subject: Re: [PATCH net v2 0/5] net: wangxun: Adjust code structure

On Wed, 2022-12-14 at 14:41 +0800, Jiawen Wu wrote:
> Remove useless structs 'txgbe_hw' and 'ngbe_hw' make the codes clear.
> And move the same codes which sets MAC address between txgbe and ngbe
> to libwx.
> 
> 

I am assuming this is for "net-next", not net since this doesn't look
like fixes but more like a signficant refactoring change.

So you may want to change this to "PATCH net-next".

> Changelog:
> v2:
>   - Split patch v1 into separate patches
>   - Fix unreasonable code logic in MAC address operations
> 
> Jiawen Wu (5):
>   net: txgbe: Remove structure txgbe_hw
>   net: ngbe: Remove structure ngbe_hw
>   net: txgbe: Move defines into unified file
>   net: ngbe: Move defines into unified file
>   net: wangxun: Move MAC address handling to libwx
> 
>  drivers/net/ethernet/wangxun/libwx/wx_hw.c    | 116 +++++++++++-
>  drivers/net/ethernet/wangxun/libwx/wx_hw.h    |   5 +-
>  drivers/net/ethernet/wangxun/libwx/wx_type.h  |  12 ++
>  drivers/net/ethernet/wangxun/ngbe/ngbe.h      |  79 --------
>  drivers/net/ethernet/wangxun/ngbe/ngbe_hw.c   |  21 +--
>  drivers/net/ethernet/wangxun/ngbe/ngbe_hw.h   |   4 +-
>  drivers/net/ethernet/wangxun/ngbe/ngbe_main.c | 125 ++++---------
>  drivers/net/ethernet/wangxun/ngbe/ngbe_type.h |  58 +++++-
>  drivers/net/ethernet/wangxun/txgbe/txgbe.h    |  43 -----
>  drivers/net/ethernet/wangxun/txgbe/txgbe_hw.c |  36 ++--
>  drivers/net/ethernet/wangxun/txgbe/txgbe_hw.h |   6 +-
>  .../net/ethernet/wangxun/txgbe/txgbe_main.c   | 174 +++---------------
>  .../net/ethernet/wangxun/txgbe/txgbe_type.h   |  22 ++-
>  13 files changed, 296 insertions(+), 405 deletions(-)
>  delete mode 100644 drivers/net/ethernet/wangxun/ngbe/ngbe.h
>  delete mode 100644 drivers/net/ethernet/wangxun/txgbe/txgbe.h
>