netdev - Re: [PATCH net-next] ravb: Fix "failed to switch device to config mode" message during unbind

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y5l2Ix2W8yPLycIB@unreal>
Date:   Wed, 14 Dec 2022 09:07:15 +0200
From:   Leon Romanovsky <leon@...nel.org>
To:     Biju Das <biju.das.jz@...renesas.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Sergey Shtylyov <s.shtylyov@....ru>,
        Phil Edworthy <phil.edworthy@...esas.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Hangbin Liu <liuhangbin@...il.com>,
        Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
        Masaru Nagai <masaru.nagai.vx@...esas.com>,
        netdev@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
        Fabrizio Castro <fabrizio.castro.jz@...esas.com>,
        stable@...r.kernel.org
Subject: Re: [PATCH net-next] ravb: Fix "failed to switch device to config
 mode" message during unbind

On Tue, Dec 13, 2022 at 09:59:38AM +0000, Biju Das wrote:
> This patch fixes the error "ravb 11c20000.ethernet eth0: failed to switch
> device to config mode" during unbind.
> 
> We are doing register access after pm_runtime_put_sync().
> 
> We usually do cleanup in reverse order of init. Currently in
> remove(), the "pm_runtime_put_sync" is not in reverse order.
> 
> Probe
> 	reset_control_deassert(rstc);
> 	pm_runtime_enable(&pdev->dev);
> 	pm_runtime_get_sync(&pdev->dev);
> 
> remove
> 	pm_runtime_put_sync(&pdev->dev);
> 	unregister_netdev(ndev);
> 	..
> 	ravb_mdio_release(priv);
> 	pm_runtime_disable(&pdev->dev);
> 
> Consider the call to unregister_netdev()
> unregister_netdev->unregister_netdevice_queue->rollback_registered_many
> that calls the below functions which access the registers after
> pm_runtime_put_sync()
>  1) ravb_get_stats
>  2) ravb_close
> 
> Fixes: a0d2f20650e8 ("Renesas Ethernet AVB PTP clock driver")

I don't know how you came to this fixes line, but the more correct one
is c156633f1353 ("Renesas Ethernet AVB driver proper")

Ant the title should need to be "PATCH net".

When you resend the patch, feel free to add my tag.

Thanks,
Reviewed-by: Leon Romanovsky <leonro@...dia.com>