netdev - [PATCH] net: phy: enhance Maxlinear GPY loopback disable function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221214082924.54990-1-lxu@maxlinear.com>
Date:   Wed, 14 Dec 2022 16:29:24 +0800
From:   Xu Liang <lxu@...linear.com>
To:     <andrew@...n.ch>, <hkallweit1@...il.com>, <netdev@...r.kernel.org>,
        <davem@...emloft.net>, <kuba@...nel.org>,
        <vee.khee.wong@...ux.intel.com>
CC:     <linux@...linux.org.uk>, <hmehrtens@...linear.com>,
        <tmohren@...linear.com>, <mohammad.athari.ismail@...el.com>,
        Xu Liang <lxu@...linear.com>
Subject: [PATCH] net: phy: enhance Maxlinear GPY loopback disable function

GPY need 3 seconds to switch out of loopback mode.

Signed-off-by: Xu Liang <lxu@...linear.com>
---
 drivers/net/phy/mxl-gpy.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/net/phy/mxl-gpy.c b/drivers/net/phy/mxl-gpy.c
index 147d7a5a9b35..81ea7c768657 100644
--- a/drivers/net/phy/mxl-gpy.c
+++ b/drivers/net/phy/mxl-gpy.c
@@ -770,9 +770,10 @@ static int gpy_loopback(struct phy_device *phydev, bool enable)
 			 enable ? BMCR_LOOPBACK : 0);
 	if (!ret) {
 		/* It takes some time for PHY device to switch
-		 * into/out-of loopback mode.
+		 * into/out-of loopback mode. It takes 3 seconds
+		 * before re-enter loopback mode.
 		 */
-		msleep(100);
+		msleep(enable ? 100 : 3000);
 	}
 
 	return ret;
-- 
2.17.1