lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 15 Dec 2022 15:00:16 +0000 From: patchwork-bot+netdevbpf@...nel.org To: Vladimir Oltean <vladimir.oltean@....com> Cc: netdev@...r.kernel.org, andrew@...n.ch, f.fainelli@...il.com, davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, mw@...ihalf.com, bigunclemax@...il.com, fido_max@...ox.ru, linux@...linux.org.uk, kabel@...nel.org Subject: Re: [PATCH net] net: dsa: mv88e6xxx: avoid reg_lock deadlock in mv88e6xxx_setup_port() Hello: This patch was applied to netdev/net.git (master) by Paolo Abeni <pabeni@...hat.com>: On Wed, 14 Dec 2022 13:01:20 +0200 you wrote: > In the blamed commit, it was not noticed that one implementation of > chip->info->ops->phylink_get_caps(), called by mv88e6xxx_get_caps(), > may access hardware registers, and in doing so, it takes the > mv88e6xxx_reg_lock(). Namely, this is mv88e6352_phylink_get_caps(). > > This is a problem because mv88e6xxx_get_caps(), apart from being > a top-level function (method invoked by dsa_switch_ops), is now also > directly called from mv88e6xxx_setup_port(), which runs under the > mv88e6xxx_reg_lock() taken by mv88e6xxx_setup(). Therefore, when running > on mv88e6352, the reg_lock would be acquired a second time and the > system would deadlock on driver probe. > > [...] Here is the summary with links: - [net] net: dsa: mv88e6xxx: avoid reg_lock deadlock in mv88e6xxx_setup_port() https://git.kernel.org/netdev/net/c/a7d82367daa6 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Powered by blists - more mailing lists