lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <cebb83f7-139d-5d40-5731-425873bae422@intel.com> Date: Thu, 15 Dec 2022 10:44:14 -0800 From: Jacob Keller <jacob.e.keller@...el.com> To: Jiri Pirko <jiri@...nulli.us>, Jakub Kicinski <kuba@...nel.org> CC: <davem@...emloft.net>, <netdev@...r.kernel.org>, <edumazet@...gle.com>, <pabeni@...hat.com>, <leon@...nel.org> Subject: Re: [RFC net-next 01/15] devlink: move code to a dedicated directory On 12/15/2022 1:51 AM, Jiri Pirko wrote: > Thu, Dec 15, 2022 at 03:01:41AM CET, kuba@...nel.org wrote: >> The devlink code is hard to navigate with 13kLoC in one file. >> I really like the way Michal split the ethtool into per-command >> files and core. It'd probably be too much to split it all up, > > Why not? While you are at it, I think that we should split it right > away. > From the cover letter it sounds like "not enough time". I like splitting things up but would be fine with just one file per sub object type like one for ports, one for regions, etc. Thanks, Jake
Powered by blists - more mailing lists