lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 15 Dec 2022 10:44:14 -0800
From:   Jacob Keller <>
To:     Jiri Pirko <>, Jakub Kicinski <>
CC:     <>, <>,
        <>, <>, <>
Subject: Re: [RFC net-next 01/15] devlink: move code to a dedicated directory

On 12/15/2022 1:51 AM, Jiri Pirko wrote:
> Thu, Dec 15, 2022 at 03:01:41AM CET, wrote:
>> The devlink code is hard to navigate with 13kLoC in one file.
>> I really like the way Michal split the ethtool into per-command
>> files and core. It'd probably be too much to split it all up,
> Why not? While you are at it, I think that we should split it right
> away.

 From the cover letter it sounds like "not enough time". I like 
splitting things up but would be fine with just one file per sub object 
type like one for ports, one for regions, etc.


Powered by blists - more mailing lists