lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 15 Dec 2022 11:17:02 -0800
From:   Jakub Kicinski <>
To:     Jiri Pirko <>
Subject: Re: [RFC net-next 04/15] devlink: protect devlink dump by the
 instance lock

On Thu, 15 Dec 2022 09:42:27 +0100 Jiri Pirko wrote:
> Thu, Dec 15, 2022 at 03:01:44AM CET, wrote:
> >Take the instance lock around devlink_nl_fill() when the dumping.
> >We are only dumping basic info so in the worst case we were only
> >risking data races until now.
> Should this be a separate patch targeted to -net with proper "fixes"
> instead?

Will do, if nothing else it will make the series smaller :)
But TBH I could not spot any issue other than perhaps non-atomic 
dump of the reload stats, but that's meh..

Powered by blists - more mailing lists