lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 15 Dec 2022 11:50:08 +0800
From:   kernel test robot <>
To:     Christian Marangi <>,
        Andrew Lunn <>,
        Florian Fainelli <>,
        Vladimir Oltean <>,
        "David S. Miller" <>,
        Eric Dumazet <>,
        Jakub Kicinski <>,
        Paolo Abeni <>,
        Rob Herring <>,
        Krzysztof Kozlowski <>,
        Jonathan Corbet <>, Pavel Machek <>,
        "Russell King (Oracle)" <>,
        John Crispin <>,,,,, Tim Harvey <>,
        Alexander Stein <>,
        Rasmus Villemoes <>
Subject: Re: [PATCH v7 10/11] net: dsa: qca8k: add LEDs support

Hi Christian,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on pavel-leds/for-next]
[also build test ERROR on robh/for-next net-next/master net/master linus/master v6.1 next-20221214]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in]

base:   git:// for-next
patch link:
patch subject: [PATCH v7 10/11] net: dsa: qca8k: add LEDs support
config: sh-allmodconfig
compiler: sh4-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git remote add linux-review
        git fetch --no-tags linux-review Christian-Marangi/Adds-support-for-PHY-LEDs-with-offload-triggers/20221215-080414
        git checkout c3cb4f8cc2edb081c2b31733ed02cb2c022320f1
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sh SHELL=/bin/bash drivers/net/dsa/qca/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <>

All errors (new ones prefixed by >>):

>> drivers/net/dsa/qca/qca8k-leds.c:383:1: error: redefinition of 'qca8k_setup_led_ctrl'
     383 | qca8k_setup_led_ctrl(struct qca8k_priv *priv)
         | ^~~~~~~~~~~~~~~~~~~~
   In file included from drivers/net/dsa/qca/qca8k-leds.c:5:
   drivers/net/dsa/qca/qca8k.h:576:19: note: previous definition of 'qca8k_setup_led_ctrl' with type 'int(struct qca8k_priv *)'
     576 | static inline int qca8k_setup_led_ctrl(struct qca8k_priv *priv)
         |                   ^~~~~~~~~~~~~~~~~~~~

vim +/qca8k_setup_led_ctrl +383 drivers/net/dsa/qca/qca8k-leds.c

   382	int
 > 383	qca8k_setup_led_ctrl(struct qca8k_priv *priv)

0-DAY CI Kernel Test Service

View attachment "config" of type "text/plain" (244140 bytes)

Powered by blists - more mailing lists