lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 14 Dec 2022 20:22:13 -0800 From: Jakub Kicinski <kuba@...nel.org> To: Maxim Georgiev <glipus@...il.com> Cc: mkubecek@...e.cz, netdev@...r.kernel.org Subject: Re: [PATCH ethtool-next v2 v2] JSON output support for Netlink implementation of --show-coalesce option On Wed, 14 Dec 2022 20:56:51 -0700 Maxim Georgiev wrote: > Add --json support for Netlink implementation of --show-coalesce option > No changes for non-JSON output for this featire. s/featire/feature/ I'd add another sentence here, something like: Note that all callers of show_u32() have to be updated but only coalesce is converted fully. To make it clear that the interspersed printf()s don't matter. One small nit pick below: > @@ -92,7 +113,12 @@ int nl_gcoalesce(struct cmd_context *ctx) > ETHTOOL_A_COALESCE_HEADER, 0); > if (ret < 0) > return ret; > - return nlsock_send_get_request(nlsk, coalesce_reply_cb); > + > + new_json_obj(ctx->json); > + ret = nlsock_send_get_request(nlsk, coalesce_reply_cb); > + delete_json_obj(); > + return ret; > + > } Empty line befre closing bracket unnecessary.
Powered by blists - more mailing lists