lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 15 Dec 2022 09:38:15 +0100 From: Jiri Pirko <jiri@...nulli.us> To: Jakub Kicinski <kuba@...nel.org> Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com, pabeni@...hat.com, jacob.e.keller@...el.com, jiri@...dia.com Subject: Re: [PATCH net 1/3] devlink: hold region lock when flushing snapshots Thu, Dec 15, 2022 at 03:01:00AM CET, kuba@...nel.org wrote: >Netdevsim triggers a splat on reload, when it destroys regions >with snapshots pending: > > WARNING: CPU: 1 PID: 787 at net/core/devlink.c:6291 devlink_region_snapshot_del+0x12e/0x140 > CPU: 1 PID: 787 Comm: devlink Not tainted 6.1.0-07460-g7ae9888d6e1c #580 > RIP: 0010:devlink_region_snapshot_del+0x12e/0x140 > Call Trace: > <TASK> > devl_region_destroy+0x70/0x140 > nsim_dev_reload_down+0x2f/0x60 [netdevsim] > devlink_reload+0x1f7/0x360 > devlink_nl_cmd_reload+0x6ce/0x860 > genl_family_rcv_msg_doit.isra.0+0x145/0x1c0 > >This is the locking assert in devlink_region_snapshot_del(), >we're supposed to be holding the region->snapshot_lock here. > >Fixes: 2dec18ad826f ("net: devlink: remove region snapshots list dependency on devlink->lock") >Signed-off-by: Jakub Kicinski <kuba@...nel.org> Ooup. Thanks for the fix. Reviewed-by: Jiri Pirko <jiri@...dia.com>
Powered by blists - more mailing lists