lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 16 Dec 2022 17:01:38 +0000 From: "Russell King (Oracle)" <linux@...linux.org.uk> To: Sean Anderson <sean.anderson@...o.com> Cc: Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>, netdev@...r.kernel.org, Paolo Abeni <pabeni@...hat.com>, Vladimir Oltean <olteanv@...il.com>, linux-kernel@...r.kernel.org, Jakub Kicinski <kuba@...nel.org>, Tim Harvey <tharvey@...eworks.com>, "David S . Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com> Subject: Re: [PATCH net-next v4 4/4] phy: aquantia: Determine rate adaptation support from registers On Fri, Dec 16, 2022 at 11:48:51AM -0500, Sean Anderson wrote: > When autonegotiation completes, the phy interface will be set based on > the global config register for that speed. If the SERDES mode is set to > something which the MAC does not support, then the link will not come > up. To avoid this, validate each combination of interface speed and link > speed which might be configured. This way, we ensure that we only > consider rate adaptation in our advertisement when we can actually use > it. > > The API for get_rate_matching requires that PHY_INTERFACE_MODE_NA be > handled properly. This is no longer true. phy_get_rate_matching() used to be called with PHY_INTERFACE_MODE_NA in phylink_bringup_phy(), but that no longer happens as we need to know whether rate matching will be used to avoid breaking stuff. See commit 7642cc28fd37 ("net: phylink: fix PHY validation with rate adaption"). The purpose of PHY_INTERFACE_MODE_NA in phylink_bringup_phy() was to deal with PHYs which switch their MAC-facing interface mode, but we know that if a PHY uses rate adaption, the assumption now is that it won't switch its MAC-facing interface, which fixes a problem that Tim Harvey was having with the rate adaption code - and I believe you agreed with. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
Powered by blists - more mailing lists