lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 16 Dec 2022 22:06:59 +0100 From: Toke Høiland-Jørgensen <toke@...e.dk> To: Kalle Valo <kvalo@...nel.org> Cc: Arnd Bergmann <arnd@...nel.org>, Pavel Skripkin <paskripkin@...il.com>, Arnd Bergmann <arnd@...db.de>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>, linux-wireless@...r.kernel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] ath9k: use proper statements in conditionals Kalle Valo <kvalo@...nel.org> writes: > Toke Høiland-Jørgensen <toke@...e.dk> writes: > >> Arnd Bergmann <arnd@...nel.org> writes: >> >>> From: Arnd Bergmann <arnd@...db.de> >>> >>> A previous cleanup patch accidentally broke some conditional >>> expressions by replacing the safe "do {} while (0)" constructs >>> with empty macros. gcc points this out when extra warnings >>> are enabled: >>> >>> drivers/net/wireless/ath/ath9k/hif_usb.c: In function 'ath9k_skb_queue_complete': >>> drivers/net/wireless/ath/ath9k/hif_usb.c:251:57: error: suggest braces around empty body in an 'else' statement [-Werror=empty-body] >>> 251 | TX_STAT_INC(hif_dev, skb_failed); >>> >>> Make both sets of macros proper expressions again. >>> >>> Fixes: d7fc76039b74 ("ath9k: htc: clean up statistics macros") >>> Signed-off-by: Arnd Bergmann <arnd@...db.de> >> >> Acked-by: Toke Høiland-Jørgensen <toke@...e.dk> > > I'll queue this to v6.2. Sounds good, thanks! -Toke
Powered by blists - more mailing lists