lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 16 Dec 2022 16:54:48 -0500 From: Paul Gazzillo <paul@...zz.com> To: "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Randy Dunlap <rdunlap@...radead.org>, Zheng Bin <zhengbin13@...wei.com>, Yang Yingliang <yangyingliang@...wei.com>, Suman Ghosh <sumang@...vell.com>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Cc: Paul Gazzillo <paul@...zz.com> Subject: [PATCH] octeontx2_pf: Select NET_DEVLINK when enabling OCTEONTX2_PF When using COMPILE_TEST, the driver controlled by OCTEONTX2_PF does not select NET_DEVLINK while the related OCTEONTX2_AF driver does. This means that when OCTEONTX2_PF is enabled from a default configuration, linker errors will occur due to undefined references to code controlled by NET_DEVLINK. 1. make.cross ARCH=x86_64 defconfig 2. make.cross ARCH=x86_64 menuconfig 3. Enable COMPILE_TEST General setup ---> Compile also drivers which will not load 4. Enable OCTEONTX2_PF Device Drivers ---> Network device support ---> Ethernet driver support ---> Marvell OcteonTX2 NIC Physical Function driver 5. Exit and save configuration. NET_DEVLINK will still be disabled. 6. make.cross ARCH=x86_64 several linker errors, for example, ld: drivers/net/ethernet/marvell/octeontx2/nic/otx2_devlink.o: in function `otx2_register_dl': otx2_devlink.c:(.text+0x142): undefined reference to `devlink_alloc_ns' This fix adds "select NET_DEVLINK" link to OCTEONTX2_PF's Kconfig specification to match OCTEONTX2_AF. Signed-off-by: Paul Gazzillo <paul@...zz.com> --- drivers/net/ethernet/marvell/octeontx2/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/marvell/octeontx2/Kconfig b/drivers/net/ethernet/marvell/octeontx2/Kconfig index 3f982ccf2c85..639893d87055 100644 --- a/drivers/net/ethernet/marvell/octeontx2/Kconfig +++ b/drivers/net/ethernet/marvell/octeontx2/Kconfig @@ -31,6 +31,7 @@ config NDC_DIS_DYNAMIC_CACHING config OCTEONTX2_PF tristate "Marvell OcteonTX2 NIC Physical Function driver" select OCTEONTX2_MBOX + select NET_DEVLINK depends on (64BIT && COMPILE_TEST) || ARM64 depends on PCI depends on PTP_1588_CLOCK_OPTIONAL -- 2.25.1
Powered by blists - more mailing lists