netdev - Re: [PATCH net] devlink: protect devlink dump by the instance lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bb678084-7050-2731-58ee-491a2f49e743@intel.com>
Date:   Fri, 16 Dec 2022 14:32:00 -0800
From:   Jacob Keller <jacob.e.keller@...el.com>
To:     Jiri Pirko <jiri@...nulli.us>, Jakub Kicinski <kuba@...nel.org>
CC:     <davem@...emloft.net>, <netdev@...r.kernel.org>,
        <edumazet@...gle.com>, <pabeni@...hat.com>, <jiri@...dia.com>,
        <moshe@...lanox.com>
Subject: Re: [PATCH net] devlink: protect devlink dump by the instance lock



On 12/16/2022 1:18 AM, Jiri Pirko wrote:
> Fri, Dec 16, 2022 at 05:44:47AM CET, kuba@...nel.org wrote:
>> On Thu, 15 Dec 2022 20:41:22 -0800 Jakub Kicinski wrote:
>>> Take the instance lock around devlink_nl_fill() when dumping,
>>> doit takes it already.
>>>
>>> We are only dumping basic info so in the worst case we were risking
>>> data races around the reload statistics. Also note that the reloads
>>> themselves had not been under the instance lock until recently, so
>>> the selection of the Fixes tag is inherently questionable.
>>>
>>> Fixes: a254c264267e ("devlink: Add reload stats")
>>
>> On second thought, the drivers can't call reload, so until we got rid
>> of the big bad mutex there could have been no race. I'll swap the tag
>> for:
>>
>> Fixes: d3efc2a6a6d8 ("net: devlink: remove devlink_mutex")
>>
>> when/if applying.
> 
> You are right.
> 
> Reviewed-by: Jiri Pirko <jiri@...dia.com>
> 
> Thanks!

Agreed!

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>