lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 16 Dec 2022 12:03:08 +0100 From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> To: Yanhong Wang <yanhong.wang@...rfivetech.com>, linux-riscv@...ts.infradead.org, netdev@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org Cc: "David S . Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Rob Herring <robh+dt@...nel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Emil Renner Berthing <kernel@...il.dk>, Richard Cochran <richardcochran@...il.com>, Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>, Peter Geis <pgwipeout@...il.com> Subject: Re: [PATCH v2 2/9] dt-bindings: net: snps,dwmac: Update the maxitems number of resets and reset-names On 16/12/2022 08:06, Yanhong Wang wrote: > Some boards(such as StarFive VisionFive v2) require more than one value > which defined by resets property, so the original definition can not > meet the requirements. In order to adapt to different requirements, > adjust the maxitems number from 1 to 3.. > > Signed-off-by: Yanhong Wang <yanhong.wang@...rfivetech.com> > --- > .../devicetree/bindings/net/snps,dwmac.yaml | 15 +++++++++++---- > 1 file changed, 11 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > index e26c3e76ebb7..7870228b4cd3 100644 > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > @@ -133,12 +133,19 @@ properties: > - ptp_ref > > resets: > - maxItems: 1 > - description: > - MAC Reset signal. > + minItems: 1 > + maxItems: 3 > + additionalItems: true > + items: > + - description: MAC Reset signal > > reset-names: > - const: stmmaceth > + minItems: 1 > + maxItems: 3 > + additionalItems: true > + contains: > + enum: > + - stmmaceth No, this is highly unspecific and you know affect all the schemas using snps,dwmac.yaml. Both lists must be specific - for your device and for others. Best regards, Krzysztof
Powered by blists - more mailing lists