lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <b72b0f7692e5693f214d6acea33b878bfb3a372c.camel@gmail.com> Date: Fri, 16 Dec 2022 08:14:24 -0800 From: Alexander H Duyck <alexander.duyck@...il.com> To: Arnd Bergmann <arnd@...nel.org>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com> Cc: Arnd Bergmann <arnd@...db.de>, Roger Quadros <rogerq@...nel.org>, Siddharth Vadapalli <s-vadapalli@...com>, Jiri Pirko <jiri@...dia.com>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] net: ethernet: ti: am65-cpsw: fix CONFIG_PM #ifdef On Thu, 2022-12-15 at 17:39 +0100, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@...db.de> > > The #ifdef check is incorrect and leads to a warning: > > drivers/net/ethernet/ti/am65-cpsw-nuss.c:1679:13: error: 'am65_cpsw_nuss_remove_rx_chns' defined but not used [-Werror=unused-function] > 1679 | static void am65_cpsw_nuss_remove_rx_chns(void *data) > > It's better to remove the #ifdef here and use the modern > SYSTEM_SLEEP_PM_OPS() macro instead. > > Fixes: 24bc19b05f1f ("net: ethernet: ti: am65-cpsw: Add suspend/resume support") > Signed-off-by: Arnd Bergmann <arnd@...db.de> > --- > drivers/net/ethernet/ti/am65-cpsw-nuss.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/net/ethernet/ti/am65-cpsw-nuss.c b/drivers/net/ethernet/ti/am65-cpsw-nuss.c > index 9decb0c7961b..ecbde83b5243 100644 > --- a/drivers/net/ethernet/ti/am65-cpsw-nuss.c > +++ b/drivers/net/ethernet/ti/am65-cpsw-nuss.c > @@ -2878,7 +2878,6 @@ static int am65_cpsw_nuss_remove(struct platform_device *pdev) > return 0; > } > > -#ifdef CONFIG_PM_SLEEP > static int am65_cpsw_nuss_suspend(struct device *dev) > { > struct am65_cpsw_common *common = dev_get_drvdata(dev); > @@ -2964,10 +2963,9 @@ static int am65_cpsw_nuss_resume(struct device *dev) > > return 0; > } > -#endif /* CONFIG_PM_SLEEP */ > > static const struct dev_pm_ops am65_cpsw_nuss_dev_pm_ops = { > - SET_SYSTEM_SLEEP_PM_OPS(am65_cpsw_nuss_suspend, am65_cpsw_nuss_resume) > + SYSTEM_SLEEP_PM_OPS(am65_cpsw_nuss_suspend, am65_cpsw_nuss_resume) > }; > > static struct platform_driver am65_cpsw_nuss_driver = { Looks good to me. Reviewed-by: Alexander Duyck <alexanderduyck@...com>
Powered by blists - more mailing lists