netdev - Re: [PATCH net v2 0/2] iavf: fix temporary deadlock and failure to set MAC address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c4109e30b644df218b7e601071a64197bf17b1f4.camel@gmail.com>
Date:   Fri, 16 Dec 2022 08:29:28 -0800
From:   Alexander H Duyck <alexander.duyck@...il.com>
To:     Michal Schmidt <mschmidt@...hat.com>,
        intel-wired-lan@...ts.osuosl.org
Cc:     Ivan Vecera <ivecera@...hat.com>, netdev@...r.kernel.org,
        Mateusz Palczewski <mateusz.palczewski@...el.com>,
        Patryk Piotrowski <patryk.piotrowski@...el.com>
Subject: Re: [PATCH net v2 0/2] iavf: fix temporary deadlock and failure to
 set MAC address

On Thu, 2022-12-15 at 23:50 +0100, Michal Schmidt wrote:
> This fixes an issue where setting the MAC address on iavf runs into a
> timeout and fails with EAGAIN.
> 
> Changes in v2:
>  - Removed unused 'ret' variable in patch 1.
>  - Added patch 2 to fix another cause of the same timeout.
> 
> Michal Schmidt (2):
>   iavf: fix temporary deadlock and failure to set MAC address
>   iavf: avoid taking rtnl_lock in adminq_task
> 
>  drivers/net/ethernet/intel/iavf/iavf.h        |   4 +-
>  .../net/ethernet/intel/iavf/iavf_ethtool.c    |  10 +-
>  drivers/net/ethernet/intel/iavf/iavf_main.c   | 135 ++++++++++--------
>  .../net/ethernet/intel/iavf/iavf_virtchnl.c   |   8 +-
>  4 files changed, 86 insertions(+), 71 deletions(-)
> 

The series looks good to me.

Reviewed-by: Alexander Duyck <alexanderduyck@...com>