lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 17 Dec 2022 12:59:09 -0800 From: Alexander Duyck <alexander.duyck@...il.com> To: Jeremy Kerr <jk@...econstruct.com.au> Cc: netdev@...r.kernel.org, Matt Johnston <matt@...econstruct.com.au>, "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Harsh Tyagi <harshtya@...gle.com> Subject: Re: [PATCH net] mctp: serial: Fix starting value for frame check sequence On Fri, Dec 16, 2022 at 10:44 PM Jeremy Kerr <jk@...econstruct.com.au> wrote: > > > Hi Alexander. > > > Since the starting value isn't unique would it possibly be worthwhile > > to look at adding a define to include/linux/crc-ccitt.h to be used to > > handle the cases where the initial value is 0xffff? I notice there > > seems to only be two starting values 0 and 0xffff for all callers so > > it might make sense to centralize it in one place. > > Yep, that would make sense if they're commonly used values, but I'm not > sure that would be suitable to include that in this fix, as it would > just add disruption to any backport work. Sorry, I didn't intend that for this patch. I was suggesting it as possible follow-on work. Thanks, - Alex
Powered by blists - more mailing lists