netdev - Re: [RFC net-next 00/10] devlink: remove the wait-for-references on unregister

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221219141000.32c94617@kernel.org>
Date:   Mon, 19 Dec 2022 14:10:00 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Jacob Keller <jacob.e.keller@...el.com>
Cc:     <jiri@...nulli.us>, <leon@...nel.org>, <netdev@...r.kernel.org>
Subject: Re: [RFC net-next 00/10] devlink: remove the wait-for-references on
 unregister

On Mon, 19 Dec 2022 09:38:09 -0800 Jacob Keller wrote:
> On 12/16/2022 5:19 PM, Jakub Kicinski wrote:
> > This set is on top of the previous RFC.
> > 
> > Move the registration and unregistration of the devlink instances
> > under their instance locks. Don't perform the netdev-style wait
> > for all references when unregistering the instance.
> 
> Could you explain the reasoning/benefits here? I'm sure some of this is
> explained in each commit message as well but it would help to understand
> the overall series.

Fair point, I'll add this:

  Yang Yingliang reported [1] a use-after-free in devlink because netdev
  paths are able to acquire a reference on the devlink instances before
  they are registered.

[1]
https://lore.kernel.org/all/20221122121048.776643-1-yangyingliang@huawei.com/