netdev - Re: [PATCH RFC 1/2] i2c: add fwnode APIs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y6Ath7zh2pv7DK1b@black.fi.intel.com>
Date:   Mon, 19 Dec 2022 11:23:19 +0200
From:   Mika Westerberg <mika.westerberg@...ux.intel.com>
To:     "Russell King (Oracle)" <linux@...linux.org.uk>
Cc:     linux-acpi@...r.kernel.org, linux-i2c@...r.kernel.org,
        netdev@...r.kernel.org, Andrew Lunn <andrew@...n.ch>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, Wolfram Sang <wsa@...nel.org>
Subject: Re: [PATCH RFC 1/2] i2c: add fwnode APIs

Hi,

On Mon, Dec 19, 2022 at 08:47:07AM +0000, Russell King (Oracle) wrote:
> Hi Mika,
> 
> On Thu, Dec 08, 2022 at 10:16:07AM +0000, Russell King (Oracle) wrote:
> > Hi Mika,
> > 
> > On Thu, Dec 08, 2022 at 12:04:02PM +0200, Mika Westerberg wrote:
> > > Hi,
> > > 
> > > On Wed, Dec 07, 2022 at 11:22:24AM +0000, Russell King (Oracle) wrote:
> > > > +EXPORT_SYMBOL(i2c_find_device_by_fwnode);
> > > > +
> > > 
> > > Drop this empty line.
> > 
> > The additional empty line was there before, and I guess is something the
> > I2C maintainer wants to logically separate the i2c device stuff from
> > the rest of the file.
> > 
> > > > +/* must call put_device() when done with returned i2c_client device */
> > > > +struct i2c_client *i2c_find_device_by_fwnode(struct fwnode_handle *fwnode);
> > > 
> > > With the kernel-docs in place you probably can drop these comments.
> > 
> > It's what is there against the other prototypes - and is very easy to
> > get wrong, as I've recently noticed in the sfp.c code as a result of
> > creating this series.
> > 
> > I find the whole _find_ vs _get_ thing a tad confusing, and there
> > probably should be just one interface with one way of putting
> > afterwards to avoid subtle long-standing bugs like this.
> > 
> > Thanks.
> 
> Do you have any comments on my reply please?

Sorry, no comments :) Thanks for the clarification.