netdev - Re: [PATCH net v4 0/3] Stop corrupting socket's task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 20 Dec 2022 02:00:18 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Benjamin Coddington <bcodding@...hat.com>
Cc:     kuba@...nel.org, pabeni@...hat.com, davem@...emloft.net,
        edumazet@...gle.com, gnault@...hat.com, philipp.reisner@...bit.com,
        lars.ellenberg@...bit.com, christoph.boehmwalder@...bit.com,
        axboe@...nel.dk, josef@...icpanda.com, kbusch@...nel.org,
        hch@....de, sagi@...mberg.me, lduncan@...e.com, cleech@...hat.com,
        michael.christie@...cle.com, jejb@...ux.ibm.com,
        martin.petersen@...cle.com, valentina.manea.m@...il.com,
        shuah@...nel.org, gregkh@...uxfoundation.org, dhowells@...hat.com,
        marc.dionne@...istor.com, sfrench@...ba.org, ccaulfie@...hat.com,
        teigland@...hat.com, mark@...heh.com, jlbec@...lplan.org,
        joseph.qi@...ux.alibaba.com, ericvh@...il.com, lucho@...kov.net,
        asmadeus@...ewreck.org, idryomov@...il.com, xiubli@...hat.com,
        chuck.lever@...cle.com, jlayton@...nel.org,
        trond.myklebust@...merspace.com, anna@...nel.org,
        steffen.klassert@...unet.com, herbert@...dor.apana.org.au,
        netdev@...r.kernel.org
Subject: Re: [PATCH net v4 0/3] Stop corrupting socket's task_frag

Hello:

This series was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@...nel.org>:

On Fri, 16 Dec 2022 07:45:25 -0500 you wrote:
> The networking code uses flags in sk_allocation to determine if it can use
> current->task_frag, however in-kernel users of sockets may stop setting
> sk_allocation when they convert to the preferred memalloc_nofs_save/restore,
> as SUNRPC has done in commit a1231fda7e94 ("SUNRPC: Set memalloc_nofs_save()
> on all rpciod/xprtiod jobs").
> 
> This will cause corruption in current->task_frag when recursing into the
> network layer for those subsystems during page fault or reclaim.  The
> corruption is difficult to diagnose because stack traces may not contain the
> offending subsystem at all.  The corruption is unlikely to show up in
> testing because it requires memory pressure, and so subsystems that
> convert to memalloc_nofs_save/restore are likely to continue to run into
> this issue.
> 
> [...]

Here is the summary with links:
  - [net,v4,1/3] net: Introduce sk_use_task_frag in struct sock.
    https://git.kernel.org/netdev/net/c/fb87bd47516d
  - [net,v4,2/3] Treewide: Stop corrupting socket's task_frag
    https://git.kernel.org/netdev/net/c/98123866fcf3
  - [net,v4,3/3] net: simplify sk_page_frag
    https://git.kernel.org/netdev/net/c/08f65892c5ee

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html