netdev - Re: [PATCH 0/2] ip/ip6_gre: Fix GRE tunnels not generating IPv6 link local addresses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fd0a2c4b-9dbd-48da-6fbc-e876d15e8f76@alliedtelesis.co.nz>
Date:   Tue, 20 Dec 2022 03:07:47 +0000
From:   Chris Packham <Chris.Packham@...iedtelesis.co.nz>
To:     Thomas Winter <Thomas.Winter@...iedtelesis.co.nz>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "dsahern@...nel.org" <dsahern@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "yoshfuji@...ux-ipv6.org" <yoshfuji@...ux-ipv6.org>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "a@...table.cc" <a@...table.cc>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH 0/2] ip/ip6_gre: Fix GRE tunnels not generating IPv6 link
 local addresses


On 20/12/22 16:06, Thomas Winter wrote:
> On Tue, 2022-12-20 at 15:32 +1300, Chris Packham wrote:
>> On 20/12/22 15:25, Chris Packham wrote:
>>> Hi Thomas,
>>>
>>> On 19/12/22 14:06, Thomas Winter wrote:
>>>> For our point-to-point GRE tunnels, they have
>>>> IN6_ADDR_GEN_MODE_NONE
>>>> when they are created then we set IN6_ADDR_GEN_MODE_EUI64 when
>>>> they
>>>> come up to generate the IPv6 link local address for the
>>>> interface.
>>>> Recently we found that they were no longer generating IPv6
>>>> addresses.
>>>>
>>>> Also, non-point-to-point tunnels were not generating any IPv6
>>>> link
>>>> local address and instead generating an IPv6 compat address,
>>>> breaking IPv6 communication on the tunnel.
>>>>
>>>> These failures were caused by commit e5dd729460ca and this patch
>>>> set
>>>> aims to resolve these issues.
>>> This appears to be a v2 of
>>> https://lore.kernel.org/all/20221218215718.1491444-1-Thomas.Winter@alliedtelesis.co.nz/#t
>>> but you haven't said so in the subject nor have you included a
>>> changelog in the patches or in the cover letter.
>>>
>>> Also for networking patches you should include either "net" or
>>> "net-next" in the subject prefix. As this appears to be a bugfix
>>> "net"
>>> is appropriate.
>>>
>> Took me a bit of looking but most of this stuff is covered by
>> https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html#netdev-faq
> Thanks, the git command I used did not put in the v2 that I expected
> and I didn't check the output properly. I will send a new patch set as
> v3.
I don't think there's any particular need to rush. I wouldn't expect 
much of a response over the holiday period.
>>>> Thomas Winter (2):
>>>>     ip/ip6_gre: Fix changing addr gen mode not generating IPv6
>>>> link local
>>>>       address
>>>>     ip/ip6_gre: Fix non-point-to-point tunnel not generating IPv6
>>>> link
>>>>       local address
>>>>
>>>>    net/ipv6/addrconf.c | 57 ++++++++++++++++++++++++------------
>>>> ---------
>>>>    1 file changed, 31 insertions(+), 26 deletions(-)