netdev - Re: [PATCH net] net: openvswitch: release vport resources on failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 21 Dec 2022 11:11:29 +0100
From:   Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
To:     Aaron Conole <aconole@...hat.com>
Cc:     netdev@...r.kernel.org, Pravin B Shelar <pshelar@....org>,
        Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Thomas Graf <tgraf@...g.ch>, dev@...nvswitch.org,
        Eelco Chaudron <echaudro@...hat.com>,
        Ilya Maximets <i.maximets@....org>,
        wangchuanlei <wangchuanlei@...pur.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: openvswitch: release vport resources on failure

On Tue, Dec 20, 2022 at 04:27:17PM -0500, Aaron Conole wrote:
> A recent commit introducing upcall packet accounting failed to properly
> release the vport object when the per-cpu stats struct couldn't be
> allocated.  This can cause dangling pointers to dp objects long after
> they've been released.
> 
> Cc: Eelco Chaudron <echaudro@...hat.com>
> Cc: wangchuanlei <wangchuanlei@...pur.com>
> Fixes: 1933ea365aa7 ("net: openvswitch: Add support to count upcall packets")
> Reported-by: syzbot+8f4e2dcfcb3209ac35f9@...kaller.appspotmail.com
> Signed-off-by: Aaron Conole <aconole@...hat.com>
> ---
Looks good, thanks

Reviewed-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
> -- 
> 2.31.1
>