lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 22 Dec 2022 11:20:07 +0100 From: Krzysztof Kozlowski <krzk@...nel.org> To: Philipp Zabel <p.zabel@...gutronix.de>, Johannes Berg <johannes@...solutions.net> Cc: netdev@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, linux-wireless@...r.kernel.org, kernel@...gutronix.de Subject: Re: [PATCH 1/2] dt-bindings: net: Add rfkill-gpio binding On 21/12/2022 11:48, Philipp Zabel wrote: > Add a device tree binding document for GPIO controlled rfkill switches. > The name, type, shutdown-gpios and reset-gpios properties are the same > as defined for ACPI. > > Signed-off-by: Philipp Zabel <p.zabel@...gutronix.de> Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. You missed several maintainers. Resend. > --- > .../devicetree/bindings/net/rfkill-gpio.yaml | 60 +++++++++++++++++++ > 1 file changed, 60 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/rfkill-gpio.yaml > > diff --git a/Documentation/devicetree/bindings/net/rfkill-gpio.yaml b/Documentation/devicetree/bindings/net/rfkill-gpio.yaml > new file mode 100644 > index 000000000000..6e62e6c96456 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/rfkill-gpio.yaml > @@ -0,0 +1,60 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/net/rfkill-gpio.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" Drop quotes. > + > +title: GPIO controlled rfkill switch > + > +maintainers: > + - Johannes Berg <johannes@...solutions.net> > + - Philipp Zabel <p.zabel@...gutronix.de> > + > +properties: > + compatible: > + const: rfkill-gpio > + > + name: > + $ref: /schemas/types.yaml#/definitions/string > + description: rfkill switch name, defaults to node name There is a generic label property. > + > + type: > + description: rfkill radio type > + enum: > + - wlan > + - bluetooth > + - ultrawideband > + - wimax > + - wwan > + - gps > + - fm > + - nfc Order the list. > + > + shutdown-gpios: > + maxItems: 1 > + > + reset-gpios: > + maxItems: 1 Reset of rfkill? It seems entire binding is a workaround of missing reset in your device. I don't think this is suitable for binding. > + > +required: > + - compatible > + - type > + > +oneOf: > + - required: > + - shutdown-gpios > + - required: > + - reset-gpios > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/gpio/gpio.h> > + > + rfkill-pcie-wlan { Generic node names, so: rfkill > + compatible = "rfkill-gpio"; > + name = "rfkill-pcie-wlan"; > + type = "wlan"; > + shutdown-gpios = <&gpio2 25 GPIO_ACTIVE_HIGH>; > + }; Best regards, Krzysztof
Powered by blists - more mailing lists