netdev - Re: [PATCH 2/2] net: rfkill: gpio: add DT support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4fa68299-cc69-3856-dc3d-75f7db3dbd7a@kernel.org>
Date:   Thu, 22 Dec 2022 11:32:51 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Philipp Zabel <p.zabel@...gutronix.de>,
        Johannes Berg <johannes@...solutions.net>
Cc:     netdev@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-wireless@...r.kernel.org,
        kernel@...gutronix.de
Subject: Re: [PATCH 2/2] net: rfkill: gpio: add DT support

On 21/12/2022 11:48, Philipp Zabel wrote:
> Allow probing rfkill-gpio via device tree. This just hooks up the
> already existing support that was started in commit 262c91ee5e52 ("net:
> rfkill: gpio: prepare for DT and ACPI support") via the "rfkill-gpio"
> compatible.
> 
> Signed-off-by: Philipp Zabel <p.zabel@...gutronix.de>
> ---
>  net/rfkill/rfkill-gpio.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/net/rfkill/rfkill-gpio.c b/net/rfkill/rfkill-gpio.c
> index f5afc9bcdee6..9f763654cd27 100644
> --- a/net/rfkill/rfkill-gpio.c
> +++ b/net/rfkill/rfkill-gpio.c
> @@ -157,12 +157,21 @@ static const struct acpi_device_id rfkill_acpi_match[] = {
>  MODULE_DEVICE_TABLE(acpi, rfkill_acpi_match);
>  #endif
>  
> +#ifdef CONFIG_OF

__maybe_unused instead

> +static const struct of_device_id rfkill_of_match[] = {
> +	{ .compatible = "rfkill-gpio", },
> +	{ },
> +};
> +MODULE_DEVICE_TABLE(of, rfkill_of_match);


Best regards,
Krzysztof