lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 21 Dec 2022 17:28:17 -0800 From: Jakub Kicinski <kuba@...nel.org> To: Hangbin Liu <liuhangbin@...il.com> Cc: netdev@...r.kernel.org, Jamal Hadi Salim <jhs@...atatu.com>, Cong Wang <xiyou.wangcong@...il.com>, Jiri Pirko <jiri@...nulli.us>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, David Ahern <dsahern@...nel.org>, Marcelo Ricardo Leitner <marcelo.leitner@...il.com> Subject: Re: [PATCHv2 net-next] sched: multicast sched extack messages On Wed, 21 Dec 2022 17:39:40 +0800 Hangbin Liu wrote: > + nlh = nlmsg_put(skb, portid, n->nlmsg_seq, NLMSG_ERROR, sizeof(*errmsg), > + NLM_F_ACK_TLVS | NLM_F_CAPPED); > + if (!nlh) > + return -1; > + > + errmsg = (struct nlmsgerr *)nlmsg_data(nlh); > + errmsg->error = 0; > + errmsg->msg = *n; > + > + if (nla_put_string(skb, NLMSGERR_ATTR_MSG, extack->_msg)) > + return -1; > + > + nlmsg_end(skb, nlh); I vote "no", notifications should not generate NLMSG_ERRORs. (BTW setting pid and seq on notifications is odd, no?)
Powered by blists - more mailing lists