lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 22 Dec 2022 16:06:33 +0000 (UTC) From: Kalle Valo <kvalo@...nel.org> To: Wang Yufen <wangyufen@...wei.com> Cc: <ajay.kathat@...rochip.com>, <claudiu.beznea@...rochip.com>, <davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>, <davidm@...uge.net>, <wangyufen@...wei.com>, <linux-wireless@...r.kernel.org>, <netdev@...r.kernel.org> Subject: Re: [wireless] wifi: wilc1000: add missing unregister_netdev() in wilc_netdev_ifc_init() Wang Yufen <wangyufen@...wei.com> wrote: > Fault injection test reports this issue: > > kernel BUG at net/core/dev.c:10731! > invalid opcode: 0000 [#1] PREEMPT SMP KASAN PTI > Call Trace: > <TASK> > wilc_netdev_ifc_init+0x19f/0x220 [wilc1000 884bf126e9e98af6a708f266a8dffd53f99e4bf5] > wilc_cfg80211_init+0x30c/0x380 [wilc1000 884bf126e9e98af6a708f266a8dffd53f99e4bf5] > wilc_bus_probe+0xad/0x2b0 [wilc1000_spi 1520a7539b6589cc6cde2ae826a523a33f8bacff] > spi_probe+0xe4/0x140 > really_probe+0x17e/0x3f0 > __driver_probe_device+0xe3/0x170 > driver_probe_device+0x49/0x120 > > The root case here is alloc_ordered_workqueue() fails, but > cfg80211_unregister_netdevice() or unregister_netdev() not be called in > error handling path. To fix add unregister_netdev goto lable to add the > unregister operation in error handling path. > > Fixes: 09ed8bfc5215 ("wilc1000: Rename workqueue from "WILC_wq" to "NETDEV-wq"") > Signed-off-by: Wang Yufen <wangyufen@...wei.com> Patch applied to wireless-next.git, thanks. 2b88974ecb35 wifi: wilc1000: add missing unregister_netdev() in wilc_netdev_ifc_init() -- https://patchwork.kernel.org/project/linux-wireless/patch/1669289902-23639-1-git-send-email-wangyufen@huawei.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Powered by blists - more mailing lists