netdev - Re: [PATCH iproute2] configure: Remove include <sys/stat.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEyMn7bK7rfXfg99RyMvyudGHd1JVP1v1r-7rzRsx4ABgP10Lg@mail.gmail.com>
Date:   Fri, 23 Dec 2022 07:30:21 +0100
From:   Heiko Thiery <heiko.thiery@...il.com>
To:     Hauke Mehrtens <hauke@...ke-m.de>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH iproute2] configure: Remove include <sys/stat.h>

Hi Hauke,

Am Mi., 21. Dez. 2022 um 23:53 Uhr schrieb Hauke Mehrtens <hauke@...ke-m.de>:
>
> The check_name_to_handle_at() function in the configure script is
> including sys/stat.h. This include fails with glibc 2.36 like this:
> ````
> In file included from /linux-5.15.84/include/uapi/linux/stat.h:5,
>                  from /toolchain-x86_64_gcc-12.2.0_glibc/include/bits/statx.h:31,
>                  from /toolchain-x86_64_gcc-12.2.0_glibc/include/sys/stat.h:465,
>                  from config.YExfMc/name_to_handle_at_test.c:3:
> /linux-5.15.84/include/uapi/linux/types.h:10:2: warning: #warning "Attempt to use kernel headers from user space, see https://kernelnewbies.org/KernelHeaders" [-Wcpp]
>    10 | #warning "Attempt to use kernel headers from user space, see https://kernelnewbies.org/KernelHeaders"
>       |  ^~~~~~~
> In file included from /linux-5.15.84/include/uapi/linux/posix_types.h:5,
>                  from /linux-5.15.84/include/uapi/linux/types.h:14:
> /linux-5.15.84/include/uapi/linux/stddef.h:5:10: fatal error: linux/compiler_types.h: No such file or directory
>     5 | #include <linux/compiler_types.h>
>       |          ^~~~~~~~~~~~~~~~~~~~~~~~
> compilation terminated.
> ````
>
> Just removing the include works, the manpage of name_to_handle_at() says
> only fcntl.h is needed.
> Signed-off-by: Hauke Mehrtens <hauke@...ke-m.de>

Unfortunately I do not have an environment with uclibc-ng < 1.0.35 to
test it against this. But I just build the package in buildroot with a
newer version and it works with your changes.

Tested-by: Heiko Thiery <heiko.thiery@...il.com>

thanks

> ---
>  configure | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/configure b/configure
> index c02753bb..18be5a03 100755
> --- a/configure
> +++ b/configure
> @@ -214,7 +214,6 @@ check_name_to_handle_at()
>      cat >$TMPDIR/name_to_handle_at_test.c <<EOF
>  #define _GNU_SOURCE
>  #include <sys/types.h>
> -#include <sys/stat.h>
>  #include <fcntl.h>
>  int main(int argc, char **argv)
>  {
> --
> 2.35.1
>