netdev - Re: [lvc-project] [PATCH] net-wan: Add check for NULL for utdm in ucc_hdlc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1c4eaa0c-cb14-83c3-304f-9cf2567f7d31@ispras.ru>
Date:   Fri, 23 Dec 2022 18:30:31 +0300
From:   Alexey Khoroshilov <khoroshilov@...ras.ru>
To:     Ekaterina Esina <eesina@...ralinux.ru>,
        Zhao Qiang <qiang.zhao@....com>
Cc:     lvc-project@...uxtesting.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, linuxppc-dev@...ts.ozlabs.org,
        "David S . Miller" <davem@...emloft.net>
Subject: Re: [lvc-project] [PATCH] net-wan: Add check for NULL for utdm in
 ucc_hdlc_probe

On 23.12.2022 17:32, Ekaterina Esina wrote:
> If uhdlc_priv_tsa != 1 then utdm is not initialized.
> And if ret != NULL then goto undo_uhdlc_init, where utdm is dereferenced.
> Same if dev == NULL.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Signed-off-by: Ekaterina Esina <eesina@...ralinux.ru>
> ---
>  drivers/net/wan/fsl_ucc_hdlc.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wan/fsl_ucc_hdlc.c b/drivers/net/wan/fsl_ucc_hdlc.c
> index 22edea6ca4b8..2ddb0f71e648 100644
> --- a/drivers/net/wan/fsl_ucc_hdlc.c
> +++ b/drivers/net/wan/fsl_ucc_hdlc.c
> @@ -1243,7 +1243,9 @@ static int ucc_hdlc_probe(struct platform_device *pdev)
>  free_dev:
>  	free_netdev(dev);
>  undo_uhdlc_init:
> -	iounmap(utdm->siram);
> +	if (utdm != NULL) {
> +		iounmap(utdm->siram);
> +	}
>  unmap_si_regs:
>  	iounmap(utdm->si_regs);
>  free_utdm:


But what is about iounmap(utdm->si_regs); that dereferences utdm a few
lines below?

--
Alexey