netdev - Re: [PATCH] net: hns3: refine the handling for VF heartbeat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202212251042.94o8kQPA-lkp@intel.com>
Date:   Sun, 25 Dec 2022 11:03:24 +0800
From:   kernel test robot <lkp@...el.com>
To:     Hao Lan <lanhao@...wei.com>, davem@...emloft.net, kuba@...nel.org
Cc:     oe-kbuild-all@...ts.linux.dev, yisen.zhuang@...wei.com,
        salil.mehta@...wei.com, edumazet@...gle.com, pabeni@...hat.com,
        richardcochran@...il.com, huangguangbin2@...wei.com,
        tanhuazhong@...wei.com, shenjian15@...wei.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH] net: hns3: refine the handling for VF heartbeat

Hi Hao,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]
[also build test WARNING on net/master linus/master v6.1 next-20221220]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Hao-Lan/net-hns3-refine-the-handling-for-VF-heartbeat/20221224-183341
patch link:    https://lore.kernel.org/r/20221224103203.5652-1-lanhao%40huawei.com
patch subject: [PATCH] net: hns3: refine the handling for VF heartbeat
config: s390-randconfig-s051-20221225
compiler: s390-linux-gcc (GCC) 12.1.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.4-39-gce1a6720-dirty
        # https://github.com/intel-lab-lkp/linux/commit/c7b7caefea0f88769e8903e2709537e1221b476f
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Hao-Lan/net-hns3-refine-the-handling-for-VF-heartbeat/20221224-183341
        git checkout c7b7caefea0f88769e8903e2709537e1221b476f
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=s390 olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=s390 SHELL=/bin/bash drivers/net/ethernet/hisilicon/hns3/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

sparse warnings: (new ones prefixed by >>)
>> drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c:4632:21: sparse: sparse: incompatible types in comparison expression (different type sizes):
>> drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c:4632:21: sparse:    unsigned long *
>> drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c:4632:21: sparse:    unsigned long long *
   drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c:5338:31: sparse: sparse: context imbalance in 'hclge_sync_fd_user_def_cfg' - unexpected unlock
   drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c:11987:23: sparse: sparse: memset with byte count of 131072

vim +4632 drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c

  4621	
  4622		u64 alive_time = HCLGE_ALIVE_SECONDS_NORMAL * HZ;
  4623		int i;
  4624	
  4625		/* start from vport 1 for PF is always alive */
  4626		for (i = 1; i < hdev->num_alloc_vport; i++) {
  4627			struct hclge_vport *vport = &hdev->vport[i];
  4628	
  4629			if (!test_bit(HCLGE_VPORT_STATE_INITED, &vport->state) ||
  4630			    !test_bit(HCLGE_VPORT_STATE_ALIVE, &vport->state))
  4631				continue;
> 4632			if (time_after(jiffies, vport->last_active_jiffies +
  4633				       alive_time)) {
  4634				clear_bit(HCLGE_VPORT_STATE_ALIVE, &vport->state);
  4635				dev_warn(&hdev->pdev->dev,
  4636					 "VF %u heartbeat timeout\n",
  4637					 i - HCLGE_VF_VPORT_START_NUM);
  4638			}
  4639		}
  4640	}
  4641	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (181102 bytes)