netdev - Re: [PATCH 1/3] USB: serial: option: Add generic MDM9207 configurations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <10cff30a-719d-f6b0-419c-36c552f4bc4b@gmail.com>
Date:   Mon, 26 Dec 2022 08:23:34 +0700
From:   Lars Melin <larsm17@...il.com>
To:     Matthew Garrett <mjg59@...f.ucam.org>, johan@...nel.org,
        bjorn@...k.no
Cc:     netdev@...r.kernel.org, linux-usb@...r.kernel.org,
        Matthew Garrett <mgarrett@...ora.tech>
Subject: Re: [PATCH 1/3] USB: serial: option: Add generic MDM9207
 configurations

On 12/26/2022 03:52, Matthew Garrett wrote:
> +	/* Qualcomm MDM9207 - 0: DIAG, 2: AT, 3: NMEA */
> +	{ USB_DEVICE(QUALCOMM_VENDOR_ID, 0xf601),
> +	  .driver_info = RSVD(1) | RSVD(4) | RSVD(5) },
> +	/* Qualcomm MDM9207 - 2: DIAG, 4: AT, 5: NMEA */
> +	{ USB_DEVICE(QUALCOMM_VENDOR_ID, 0xf622),
> +	  .driver_info = RSVD(0) | RSVD(1) | RSVD(3) | RSVD(6) },

Please tell what the reserved interfaces are used for and why they 
should be blacklisted.
The generic Qualcomm driver for 05c6:f601 (which is used by at least one 
other brand/reseller) specifies that interface#1 is for USB Modem (ppp 
dial-up).
I assume that you posses this dongle since you add support for it so you 
can easily verify that function which I assume has not been disabled in 
your version.

thanks
Lars