netdev - Re: [net PATCH 1/2] dt-bindings: net: marvell,orion-mdio: Fix error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9a2ae843-1cc8-b3c7-1d63-da56547f81c8@linaro.org>
Date:   Tue, 27 Dec 2022 09:06:58 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Michał Grzelak <mig@...ihalf.com>,
        devicetree@...r.kernel.org
Cc:     davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, andrew@...n.ch,
        chris.packham@...iedtelesis.co.nz, netdev@...r.kernel.org,
        upstream@...ihalf.com, linux-kernel@...r.kernel.org
Subject: Re: [net PATCH 1/2] dt-bindings: net: marvell,orion-mdio: Fix error

On 27/12/2022 02:05, Michał Grzelak wrote:
> Fix 'unevaluated properties error' during 'make dtbs_check' appearing on
> arm device trees by defining generic 'ethernet-phy' subnode in
> marvell,orion-mdio.yaml.

Instead of long test just paste a bit of warning message. Much easier to
read.

> 
> Fixes: 0781434af811f ("dt-bindings: net: orion-mdio: Convert to JSON
> schema")

Don't wrap tags.

> Signed-off-by: Michał Grzelak <mig@...ihalf.com>
> ---
>  Documentation/devicetree/bindings/net/marvell,orion-mdio.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/marvell,orion-mdio.yaml b/Documentation/devicetree/bindings/net/marvell,orion-mdio.yaml
> index d2906b4a0f59..2b2b3f8709fc 100644
> --- a/Documentation/devicetree/bindings/net/marvell,orion-mdio.yaml
> +++ b/Documentation/devicetree/bindings/net/marvell,orion-mdio.yaml
> @@ -35,6 +35,10 @@ properties:
>      minItems: 1
>      maxItems: 4
>  
> +patternProperties:
> +  '^ethernet-phy':

ethernet-phy@ is already accepted via mdio, so this looks wrong. You
need to rather fix the DTS.


Best regards,
Krzysztof