netdev - Re: [PATCHv2 net-next] sched: multicast sched extack messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 28 Dec 2022 16:41:19 +0800
From:   Hangbin Liu <liuhangbin@...il.com>
To:     Jamal Hadi Salim <jhs@...atatu.com>
Cc:     David Ahern <dsahern@...nel.org>, Jakub Kicinski <kuba@...nel.org>,
        netdev@...r.kernel.org, Cong Wang <xiyou.wangcong@...il.com>,
        Jiri Pirko <jiri@...nulli.us>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>,
        Marcelo Ricardo Leitner <marcelo.leitner@...il.com>,
        Vlad Buslov <vladbu@...dia.com>
Subject: Re: [PATCHv2 net-next] sched: multicast sched extack messages

On Tue, Dec 27, 2022 at 11:23:23AM -0500, Jamal Hadi Salim wrote:
> Hi Hangbin,
> 
> On Mon, Dec 26, 2022 at 10:58 PM Hangbin Liu <liuhangbin@...il.com> wrote:
> >
> > Hi Jamal,
> > On Mon, Dec 26, 2022 at 11:31:24AM -0500, Jamal Hadi Salim wrote:
> > > My only concern is this is not generic enough i.e can other objects
> > > outside of filters do this?
> > > You are still doing it only for the filter (in tfilter_set_nl_ext() -
> > > sitting in cls_api)
> > > As i mentioned earlier, actions can also be offloaded independently;
> > > would this work with actions extack?
> > > If it wont work then perhaps we should go the avenue of using
> > > per-object(in this case filter) specific attributes
> > > to carry the extack as suggested by Jakub earlier.
> >
> > Yes, I think we can do it on action objects, e.g. call tfilter_set_nl_ext()
> > in tca_get_fill:
> >
> > tcf_add_notify() - tca_get_fill()
> >
> > I will rename tfilter_set_nl_ext() to tc_set_nl_ext(). BTW, should we also
> > do it in qdisc/ class?
> >
> > tclass_notify() - tc_fill_tclass()
> > qdisc_notify() - tc_fill_qdisc()
> >
> 
> The only useful cases imo are the ones that do h/w offload. So those two seem
> reasonable. Not sure where you place that tc_set_nl_ext() so it is
> visible for all.

How about put tc_set_nl_ext() to net/sched/sch_generic.c?

Hangbin