netdev - Re: [PATCH net-next] r8169: disable ASPM in case of tx timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ca237edb-eda8-84cf-22d4-b841a06e3848@gmail.com>
Date:   Thu, 29 Dec 2022 12:30:21 +0100
From:   Heiner Kallweit <hkallweit1@...il.com>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     Jakub Kicinski <kuba@...nel.org>,
        David Miller <davem@...emloft.net>,
        Realtek linux nic maintainers <nic_swsd@...ltek.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] r8169: disable ASPM in case of tx timeout

On 28.12.2022 23:05, Stephen Hemminger wrote:
> On Wed, 28 Dec 2022 22:30:56 +0100
> Heiner Kallweit <hkallweit1@...il.com> wrote:
> 
>> There are still single reports of systems where ASPM incompatibilities
>> cause tx timeouts. It's not clear whom to blame, so let's disable
>> ASPM in case of a tx timeout.
>>
>> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
> 
> Wouldn't a log message be appropriate here.
> 
> 	netdev_WARN_ONCE(tp->dev, "ASPM disabled on Tx timeout\n");

Right, that's something I could add. Message will be printed only
if return code of pci_disable_link_state() indicates success.
And I'd use netdev_warn_once() instead of netdev_WARN_ONCE(),
because net core prints a stack trace already in case of tx timeout.