netdev - Re: [PATCH net] net: dpaa2-mac: Get serdes only for backplane links

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cf215c60-8019-924f-c4d2-4204bb6a87f3@seco.com>
Date:   Fri, 30 Dec 2022 10:23:49 -0500
From:   Sean Anderson <sean.anderson@...o.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Ioana Ciornei <ioana.ciornei@....com>,
        "David S . Miller" <davem@...emloft.net>,
        Russell King <linux@...linux.org.uk>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net] net: dpaa2-mac: Get serdes only for backplane links

On 12/29/22 23:09, Jakub Kicinski wrote:
> On Tue, 27 Dec 2022 18:09:18 -0500 Sean Anderson wrote:
>> +	if (!(mac->features & !DPAA2_MAC_FEATURE_PROTOCOL_CHANGE) ||
> 
> This line is odd as sparse points out

Ah, you're right.

--Sean