[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CACGkMEsL2Tm=J-nazDEebO0_8=S_4hW2vKdLpZy7ab=Yr92cPw@mail.gmail.com>
Date: Fri, 30 Dec 2022 11:40:32 +0800
From: Jason Wang <jasowang@...hat.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: "Michael S. Tsirkin" <mst@...hat.com>, davem@...emloft.net,
edumazet@...gle.com, pabeni@...hat.com,
virtualization@...ts.linux-foundation.org, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, maxime.coquelin@...hat.com,
alvaro.karsz@...id-run.com, eperezma@...hat.com
Subject: Re: [PATCH 1/4] virtio-net: convert rx mode setting to use workqueue
On Fri, Dec 30, 2022 at 10:51 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Tue, 27 Dec 2022 17:06:10 +0800 Jason Wang wrote:
> > > Hmm so user tells us to e.g enable promisc. We report completion
> > > but card is still dropping packets. I think this
> > > has a chance to break some setups.
> >
> > I think all those filters are best efforts, am I wrong?
>
> Are the flags protected by the addr lock which needs BH, tho?
>
> Taking netif_addr_lock_bh() to look at dev->flags seems a bit
> surprising to me.
>
Yes, RTNL should be sufficient here. Will fix it.
Thanks
Powered by blists - more mailing lists