netdev - Re: [RFC net-next 06/10] devlink: don't require setting features before registration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y7L3Xrh7V33Ijr4M@nanopsycho>
Date:   Mon, 2 Jan 2023 16:25:18 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     jacob.e.keller@...el.com, leon@...nel.org, netdev@...r.kernel.org
Subject: Re: [RFC net-next 06/10] devlink: don't require setting features
 before registration

Sat, Dec 17, 2022 at 02:19:49AM CET, kuba@...nel.org wrote:
>Requiring devlink_set_features() to be run before devlink is
>registered is overzealous. devlink_set_features() itself is
>a leftover from old workarounds which were trying to prevent
>initiating reload before probe was complete.

Wouldn't it be better to remove this entirely? I don't think it is
needed anymore.


>
>Signed-off-by: Jakub Kicinski <kuba@...nel.org>
>---
> net/devlink/core.c | 2 --
> 1 file changed, 2 deletions(-)
>
>diff --git a/net/devlink/core.c b/net/devlink/core.c
>index 413b92534ad6..f30fc167c8ad 100644
>--- a/net/devlink/core.c
>+++ b/net/devlink/core.c
>@@ -131,8 +131,6 @@ struct devlink *devlinks_xa_find_get(struct net *net, unsigned long *indexp)
>  */
> void devlink_set_features(struct devlink *devlink, u64 features)
> {
>-	ASSERT_DEVLINK_NOT_REGISTERED(devlink);
>-
> 	WARN_ON(features & DEVLINK_F_RELOAD &&
> 		!devlink_reload_supported(devlink->ops));
> 	devlink->features = features;
>-- 
>2.38.1
>