netdev - Re: [PATCH net] net: dpaa: Fix dtsec check for PCS availability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <04c0adce-3850-aa73-6bad-a10973d83df3@gmail.com>
Date:   Tue, 3 Jan 2023 09:37:41 -0500
From:   Sean Anderson <seanga2@...il.com>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     Madalin Bucur <madalin.bucur@....com>,
        "David S . Miller" <davem@...emloft.net>,
        Sean Anderson <sean.anderson@...o.com>, netdev@...r.kernel.org,
        Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Christian Zigotzky <info@...osoft.de>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: dpaa: Fix dtsec check for PCS availability

On 1/3/23 04:15, Jiri Pirko wrote:
> Tue, Jan 03, 2023 at 07:50:38AM CET, seanga2@...il.com wrote:
>> We want to fail if the PCS is not available, not if it is available. Fix
> 
> It is odd to read plural maiestaticus in patch desctiption :) Better to
> stick with describing what code does wrong and then telling the codebase
> what to do.

Writing a kernel is a collaborative effort :)

>> this condition.
>>
>> Fixes: 5d93cfcf7360 ("net: dpaa: Convert to phylink")
>> Reported-by: Christian Zigotzky <info@...osoft.de>
>> Signed-off-by: Sean Anderson <seanga2@...il.com>
> 
> Reviewed-by: Jiri Pirko <jiri@...dia.com>