netdev - Re: [PATCH wpan-next v2 3/6] ieee802154: Introduce a helper to validate a channel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230103155950.7cf2e5fe@xps-13>
Date:   Tue, 3 Jan 2023 15:59:50 +0100
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Stefan Schmidt <stefan@...enfreihafen.org>
Cc:     Alexander Aring <alex.aring@...il.com>, linux-wpan@...r.kernel.org,
        David Girault <david.girault@...vo.com>,
        Romuald Despres <romuald.despres@...vo.com>,
        Frederic Blain <frederic.blain@...vo.com>,
        Nicolas Schodet <nico@...fr.eu.org>,
        Guilhem Imberton <guilhem.imberton@...vo.com>,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>, netdev@...r.kernel.org
Subject: Re: [PATCH wpan-next v2 3/6] ieee802154: Introduce a helper to
 validate a channel

Hi Stefan,

stefan@...enfreihafen.org wrote on Tue, 3 Jan 2023 15:14:46 +0100:

> Hello Miquel.
> 
> On 17.12.22 01:02, Miquel Raynal wrote:
> > This helper for now only checks if the page member and channel member
> > are valid (in the specification range) and supported (by checking the
> > device capabilities). Soon two new parameters will be introduced and
> > having this helper will let us only modify its content rather than
> > modifying the logic everywhere else in the subsystem.
> > 
> > There is not functional change.
> > 
> > Signed-off-by: Miquel Raynal <miquel.raynal@...tlin.com>
> > ---
> >   include/net/cfg802154.h   | 11 +++++++++++
> >   net/ieee802154/nl802154.c |  3 +--
> >   2 files changed, 12 insertions(+), 2 deletions(-)
> > 
> > diff --git a/include/net/cfg802154.h b/include/net/cfg802154.h
> > index 76d4f95e9974..11bedfa96371 100644
> > --- a/include/net/cfg802154.h
> > +++ b/include/net/cfg802154.h
> > @@ -246,6 +246,17 @@ static inline void wpan_phy_net_set(struct wpan_phy *wpan_phy, struct net *net)
> >   	write_pnet(&wpan_phy->_net, net);
> >   }  
> >   > +static inline bool ieee802154_chan_is_valid(struct wpan_phy *phy,  
> > +                                            u8 page, u8 channel)
> > +{
> > +        if (page > IEEE802154_MAX_PAGE ||
> > +            channel > IEEE802154_MAX_CHANNEL ||
> > +            !(phy->supported.channels[page] & BIT(channel)))
> > +                return false;
> > +
> > +	return true;
> > +}
> > +  
> 
> This patch has some indent problems.

I will check all the patches of this series and fix what checkpatch.pl
reports.

https://media.tenor.com/025m1-otvn0AAAAC/shame-game-of-thrones.gif

Cheers,
Miquèl

> 
> Commit 6bbb25ee282b ("ieee802154: Introduce a helper to validate a channel")
> ----------------------------------------------------------------------------
> ERROR: code indent should use tabs where possible
> #31: FILE: include/net/cfg802154.h:250:
> +                                            u8 page, u8 channel)$
> 
> WARNING: please, no spaces at the start of a line
> #31: FILE: include/net/cfg802154.h:250:
> +                                            u8 page, u8 channel)$
> 
> ERROR: code indent should use tabs where possible
> #33: FILE: include/net/cfg802154.h:252:
> +        if (page > IEEE802154_MAX_PAGE ||$
> 
> WARNING: please, no spaces at the start of a line
> #33: FILE: include/net/cfg802154.h:252:
> +        if (page > IEEE802154_MAX_PAGE ||$
> 
> ERROR: code indent should use tabs where possible
> #34: FILE: include/net/cfg802154.h:253:
> +            channel > IEEE802154_MAX_CHANNEL ||$
> 
> WARNING: please, no spaces at the start of a line
> #34: FILE: include/net/cfg802154.h:253:
> +            channel > IEEE802154_MAX_CHANNEL ||$
> 
> ERROR: code indent should use tabs where possible
> #35: FILE: include/net/cfg802154.h:254:
> +            !(phy->supported.channels[page] & BIT(channel)))$
> 
> WARNING: please, no spaces at the start of a line
> #35: FILE: include/net/cfg802154.h:254:
> +            !(phy->supported.channels[page] & BIT(channel)))$
> 
> ERROR: code indent should use tabs where possible
> #36: FILE: include/net/cfg802154.h:255:
> +                return false;$
> 
> WARNING: please, no spaces at the start of a line
> #36: FILE: include/net/cfg802154.h:255:
> +                return false;$
> 
> total: 5 errors, 5 warnings, 0 checks, 26 lines checked
> 
> regards
> Stefan Schmidt