netdev - Re: [PATCH v8] vmxnet3: Add XDP support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202301031234.A2W7CLSu-lkp@intel.com>
Date:   Tue, 3 Jan 2023 12:50:49 +0800
From:   kernel test robot <lkp@...el.com>
To:     William Tu <u9012063@...il.com>, netdev@...r.kernel.org
Cc:     oe-kbuild-all@...ts.linux.dev, tuc@...are.com, gyang@...are.com,
        doshir@...are.com, alexander.duyck@...il.com,
        gerhard@...leder-embedded.com
Subject: Re: [PATCH v8] vmxnet3: Add XDP support.

Hi William,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v6.2-rc2 next-20221226]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/William-Tu/vmxnet3-Add-XDP-support/20230103-102353
patch link:    https://lore.kernel.org/r/20230103022232.52412-1-u9012063%40gmail.com
patch subject: [PATCH v8] vmxnet3: Add XDP support.
config: s390-allyesconfig
compiler: s390-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/b111c9fa3603f8fc62a1e6e34a71ccb98fc0abc2
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review William-Tu/vmxnet3-Add-XDP-support/20230103-102353
        git checkout b111c9fa3603f8fc62a1e6e34a71ccb98fc0abc2
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=s390 olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash drivers/net/vmxnet3/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/net/vmxnet3/vmxnet3_xdp.c: In function 'vmxnet3_xdp_xmit':
>> drivers/net/vmxnet3/vmxnet3_xdp.c:244:30: warning: variable 'nq' set but not used [-Wunused-but-set-variable]
     244 |         struct netdev_queue *nq;
         |                              ^~


vim +/nq +244 drivers/net/vmxnet3/vmxnet3_xdp.c

   236	
   237	/* ndo_xdp_xmit */
   238	int
   239	vmxnet3_xdp_xmit(struct net_device *dev,
   240			 int n, struct xdp_frame **frames, u32 flags)
   241	{
   242		struct vmxnet3_adapter *adapter;
   243		struct vmxnet3_tx_queue *tq;
 > 244		struct netdev_queue *nq;
   245		int i, err, cpu;
   246		int tq_number;
   247	
   248		adapter = netdev_priv(dev);
   249	
   250		if (unlikely(test_bit(VMXNET3_STATE_BIT_QUIESCED, &adapter->state)))
   251			return -ENETDOWN;
   252		if (unlikely(test_bit(VMXNET3_STATE_BIT_RESETTING, &adapter->state)))
   253			return -EINVAL;
   254	
   255		tq_number = adapter->num_tx_queues;
   256		cpu = smp_processor_id();
   257		tq = &adapter->tx_queue[cpu % tq_number];
   258		if (tq->stopped)
   259			return -ENETDOWN;
   260	
   261		nq = netdev_get_tx_queue(adapter->netdev, tq->qid);
   262	
   263		for (i = 0; i < n; i++) {
   264			err = vmxnet3_xdp_xmit_frame(adapter, frames[i], tq, true);
   265			if (err) {
   266				tq->stats.xdp_xmit_err++;
   267				break;
   268			}
   269		}
   270		tq->stats.xdp_xmit += i;
   271	
   272		return i;
   273	}
   274	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (311941 bytes)